3.16.61-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Tushar Behera <tusha...@samsung.com>

commit ec5734c41bee2ee7c938a8f34853d31cada7e67a upstream.

'err' is uninitialized, rather print the error code directly.

This also fixes following warning.
drivers/usb/misc/usb3503.c: In function ‘usb3503_probe’:
drivers/usb/misc/usb3503.c:195:11: warning: ‘err’ may be used uninitialized
in this function [-Wmaybe-uninitialized]
    dev_err(dev, "unable to request refclk (%d)\n", err);

Signed-off-by: Tushar Behera <tusha...@samsung.com>
Acked-by: Marek Szyprowski <m.szyprow...@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 drivers/usb/misc/usb3503.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/usb/misc/usb3503.c
+++ b/drivers/usb/misc/usb3503.c
@@ -192,7 +192,8 @@ static int usb3503_probe(struct usb3503
 
                clk = devm_clk_get(dev, "refclk");
                if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
-                       dev_err(dev, "unable to request refclk (%d)\n", err);
+                       dev_err(dev, "unable to request refclk (%ld)\n",
+                                       PTR_ERR(clk));
                        return PTR_ERR(clk);
                }
 

Reply via email to