On Tue, Jul 10 2007, Andrew Morton wrote: > On Tue, 10 Jul 2007 23:00:59 GMT Linux Kernel Mailing List > <[email protected]> wrote: > > > +static int shmem_readpage(struct file *file, struct page *page) > > +{ > > + struct inode *inode = page->mapping->host; > > + int error = shmem_getpage(inode, page->index, &page, SGP_CACHE, NULL); > > + unlock_page(page); > > + return error; > > +} > > Worried. shmem_getpage() does > > done: > if (*pagep != filepage) { > unlock_page(filepage); > *pagep = filepage; > } > return 0; > > so we end up unlocking an unlocked page?
It certainly looks like it - Hugh? -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
