On Sun, Nov 11, 2018 at 12:29 PM Pavel Machek <[email protected]> wrote: > > > +static void __reg_io_start(const struct upboard_ddata * const ddata) > > +{ > > + /* > > + * CLEAR signal must be pulsed low before any register access. > > + * This resets internal counters in the controller and marks > > + * the start of a new register access. > > + */ > > + set_clear(ddata, 0); > > + set_clear(ddata, 1); > > +} > > We normally reserve __ prefix for different stuff. This is not using > it appropriately.
+1 I actively dislike __underscore_notation as it seems to be completely arbitrary and ambiguous. I think even do_the_stuff_reg_io_start() is better. But please come up with something to the point and descriptive! :) Yours, Linus Walleij
