From: Masahiro Yamada Sent: November 16, 2018 at 7:37:46 AM GMT > To: Nadav Amit <na...@vmware.com> > Cc: Ingo Molnar <mi...@redhat.com>, Michal Marek <michal.l...@markovi.net>, > Thomas Gleixner <t...@linutronix.de>, Borislav Petkov <b...@alien8.de>, H. > Peter Anvin <h...@zytor.com>, X86 ML <x...@kernel.org>, Linux Kbuild mailing > list <linux-kbu...@vger.kernel.org>, Linux Kernel Mailing List > <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH v2 2/2] x86: set a dependency on macros.S > > > On Thu, Nov 15, 2018 at 1:01 PM Nadav Amit <na...@vmware.com> wrote: >> Changes in macros.S should trigger the recompilation of all C files, as >> the macros might need to affect their compilation. >> >> Acked-by: Ingo Molnar <mi...@kernel.org> >> Signed-off-by: Nadav Amit <na...@vmware.com> >> --- > > When we talked about this last time, > we agreed to not do this > because a single line change in asm headers > would cause global rebuilding. > > Did you change your mind?
I was wrong (and you were right? I don’t quite remember). Anyhow, another patch I work on made me realize how wrong I was. If required, we can extract the macros from some of the header files into separate header files to prevent unnecessary rebuilds. Thanks, Nadav
