On Thu, Nov 22, 2018 at 3:05 PM Peter Zijlstra <pet...@infradead.org> wrote:
>
> On Mon, Nov 19, 2018 at 02:18:50PM +0000, Quentin Perret wrote:
> > + if (rd->pd)
> > + pr_warn("rd %*pbl: Disabling EAS, schedutil
> > is mandatory\n",
> > + cpumask_pr_args(cpu_map));
> > + goto free;
>
> I would have preferred just not allowing the governor to change at all,
> but if you want to allow that, this is, I suppose, the best you can do.
>
> Rafael, are you otherwise OK with the grubbing inside cpufreq?
Sort of. :-)
I would put the sched_cpufreq_governor_change() header (and the static
inline stub of it) into linux/cpufreq.h (instead of
linux/sched/cpufreq.h) so that cpufreq.c doesn't have to include
linux/sched/cpufreq.h which is kind of confusing.
Apart from that the changes are fine by me.
