On Sat, Nov 24, 2018 at 6:06 PM Miguel Ojeda <[email protected]> wrote: > > On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck > <[email protected]> wrote: > > > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > > reported lots of "unknown expression" warnings from container_of(), > > > which seemed false positive. > > > > > > I addressed this in [1], but fixing Sparse is the right thing to do. > > > > > > The issue was fixed by Sparse commit 0eb8175d3e9c ("fix expansion of > > > function designator"), but it will take time until the fixed version > > > of Sparse is widely available. > > > > > > Disable the container_of() type checks for Sparse for now. > > > > I would prefer that developers upgrade their version of sparse but ... > > > > Reviewed-by: Luc Van Oostenryck <[email protected]> > > Indeed. If someone is writing code for the latest kernels, I think it > is reasonable to assume they are able to use the latest sparse too, > since it is not required for compilation anyway.
I am OK with either way. I leave this to Andrew. -- Best Regards Masahiro Yamada
