On Sun, Nov 25, 2018 at 07:33:32PM +0100, Thomas Gleixner wrote:
> The Spectre V2 printout in cpu_show_common() handles conditionals for the
> various mitigation methods directly in the sprintf() argument list. That's
> hard to read and will become unreadable if more complex decisions need to
> be made for a particular method.
>
> Move the conditionals for STIBP and IBPB string selection into helper
> functions, so they can be extended later on.
>
> Signed-off-by: Tim Chen <tim.c.c...@linux.intel.com>
> Signed-off-by: Thomas Gleixner <t...@linutronix.de>
>
> ---
> arch/x86/kernel/cpu/bugs.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
Just a nitpick:
That subject should probably be more like:
"x86/speculation: Move cpu_show_common() string generation in separate
functions"
or so, as it is not really reorganizing - just carving out functionality.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
