On Thu, Nov 29, 2018 at 5:36 PM Andy Gross <[email protected]> wrote: > > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > We need to check the call to cmd_db_read_aux_data() for the error case, > > so that we don't continue and use potentially uninitialized values for > > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler > > warnings: > > > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function > > 'a6xx_gmu_rpmh_arc_votes_init.isra.12': > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is > > used uninitialized in this function [-Wuninitialized] > > pri_count >>= 1; > > ^~~ > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may > > be used uninitialized in this function > > [-Wmaybe-uninitialized] > > sec_count >>= 1; > > ^~~ > > > > Reported-by: Stephen Rothwell <[email protected]> > > Reported-by: kbuild test robot <[email protected]> > > Cc: Jordan Crouse <[email protected]> > > Cc: Bjorn Andersson <[email protected]> > > Cc: Evan Green <[email protected]> > > Cc: Jordan Crouse <[email protected]> > > Cc: Rob Clark <[email protected]> > > Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in > > cmd_db_read_aux_data()") > > Signed-off-by: Stephen Boyd <[email protected]> > > Thanks for the patch. Queueing this up. >
from talking to agross on IRC, seems like this becomes an issue w/ other patches he has queued up for 4.21, and I don't think this should conflict w/ other stuff I have, so Acked-by: Rob Clark <[email protected]> for Andy picking up this one BR, -R > > Andy
