[Re: [PATCH 12/22] mfd: sta2x11: drop unused MODULE_ tags from non-modular code] On 03/12/2018 (Mon 11:14) Lee Jones wrote:
> On Sun, 02 Dec 2018, Paul Gortmaker wrote: > > > The Kconfig currently controlling compilation of this code is: > > > > drivers/mfd/Kconfig:config MFD_STA2X11 > > drivers/mfd/Kconfig: bool "STMicroelectronics STA2X11" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the couple traces of modular infrastructure use, so that > > when reading the driver there is no doubt it is builtin-only. [...] > > Cc: Lee Jones <lee.jo...@linaro.org> > > I think you should add some of the driver developers. Fair point, but note that get_maintainers doesn't list any developers, and neither of the driver authors put an e-mail address in the driver. $ gm drivers/mfd/sta2x11-mfd.c ------------------------------------------------------ Lee Jones <lee.jo...@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD)) linux-kernel@vger.kernel.org (open list) ------------------------------------------------------ Cc: Lee Jones <lee.jo...@linaro.org> Cc: linux-kernel@vger.kernel.org ------------------------------------------------------ $ Looking in git history, I was able to find two e-mail, but one hasn't been used in 5+ years, so hopefully it is still active. I have added both to the Cc: of this e-mail and added them to the commit below. Alessandro, Davide - you can find additional context regarding why we are making these changes in the [00/22] e-mail that can be found here: https://lore.kernel.org/lkml/1543811009-15112-1-git-send-email-paul.gortma...@windriver.com/ Thanks, Paul. -- >From 34742ffbf343abca07f9d0d680ebfebaedd993c9 Mon Sep 17 00:00:00 2001 From: Paul Gortmaker <paul.gortma...@windriver.com> Date: Wed, 6 Jul 2016 16:46:39 -0400 Subject: [PATCH] mfd: sta2x11: drop unused MODULE_ tags from non-modular code The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_STA2X11 drivers/mfd/Kconfig: bool "STMicroelectronics STA2X11" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modular infrastructure use, so that when reading the driver there is no doubt it is builtin-only. We delete the MODULE_LICENSE tag etc. since all that information is already contained at the top of the file in the comments. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We replace module.h with init.h and export.h ; the latter since the file does export some symbols. Cc: Lee Jones <lee.jo...@linaro.org> Cc: Alessandro Rubini <rub...@gnudd.com> Cc: Davide Ciminaghi <cimina...@gnudd.com> Signed-off-by: Paul Gortmaker <paul.gortma...@windriver.com> diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c index 3aeafa228baf..cab9aabcaa1f 100644 --- a/drivers/mfd/sta2x11-mfd.c +++ b/drivers/mfd/sta2x11-mfd.c @@ -1,4 +1,6 @@ /* + * STA2x11 mfd for GPIO, SCTL and APBREG + * * Copyright (c) 2009-2011 Wind River Systems, Inc. * Copyright (c) 2011 ST Microelectronics (Alessandro Rubini, Davide Ciminaghi) * @@ -18,7 +20,8 @@ */ #include <linux/kernel.h> -#include <linux/module.h> +#include <linux/init.h> +#include <linux/export.h> #include <linux/spinlock.h> #include <linux/errno.h> #include <linux/device.h> @@ -653,8 +656,3 @@ static int __init sta2x11_mfd_init(void) */ subsys_initcall(sta2x11_drivers_init); rootfs_initcall(sta2x11_mfd_init); - -MODULE_LICENSE("GPL v2"); -MODULE_AUTHOR("Wind River"); -MODULE_DESCRIPTION("STA2x11 mfd for GPIO, SCTL and APBREG"); -MODULE_DEVICE_TABLE(pci, sta2x11_mfd_tbl); -- 2.7.4
