Quoting Jianxin Pan (2018-12-03 18:39:34) > Hi Stephen, > > On 2018/12/4 6:45, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-11-15 04:18:30) > >> diff --git a/include/dt-bindings/clock/amlogic,mmc-clkc.h > >> b/include/dt-bindings/clock/amlogic,mmc-clkc.h > >> new file mode 100644 > >> index 0000000..162b949 > >> --- /dev/null > >> +++ b/include/dt-bindings/clock/amlogic,mmc-clkc.h > >> @@ -0,0 +1,17 @@ > >> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > >> +/* > >> + * Meson MMC sub clock tree IDs > >> + * > >> + * Copyright (c) 2018 Amlogic, Inc. All rights reserved. > >> + * Author: Yixun Lan <yixun....@amlogic.com> > >> + */ > >> + > >> +#ifndef __MMC_CLKC_H > >> +#define __MMC_CLKC_H > >> + > >> +#define CLKID_MMC_DIV 1 > > > > Why does the define numbering start with 1 instead of 0? > > > The Clock ID 0 is used by CLKID_MMC_MUX. > CLKID_MMC_MUX is an internal clock which defined in > drivers/clk/meson/mmc-clkc.c, and it's the parent of CLKID_MMC_DIV.
Ok, thanks.