Hi
Thank you for your comments.
On 2018/12/04 20:23, Masahiro Yamada wrote:
Hi Sugaya-san
On Mon, Nov 19, 2018 at 10:01 AM Sugaya Taichi
<[email protected]> wrote:
Add Milbeaut M10V pinctrl.
The M10V has the pins that can be used GPIOs or take multiple other
functions.
Signed-off-by: Sugaya Taichi <[email protected]>
This patch was sent to:
[email protected],
[email protected],
[email protected],
[email protected],
[email protected]
Unfortunately, the most important ML
[email protected]
was not addressed.
The pinctrl maintainer may not notice this patch.
Ah I took a critical mistake...
diff --git a/drivers/pinctrl/pinctrl-m10v.c b/drivers/pinctrl/pinctrl-m10v.c
new file mode 100644
index 0000000..d4ca713
--- /dev/null
+++ b/drivers/pinctrl/pinctrl-m10v.c
@@ -0,0 +1,765 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2018 Socionext Ltd.
+ * Copyright (C) 2015 Linaro Ltd.
+ * Author: Jassi Brar <[email protected]>
My company name is "Socionext Inc." instead of "Socionext Ltd."
Yes, modify it.
+static struct platform_driver m10v_pinctrl_driver = {
+ .probe = m10v_pinctrl_probe,
+ .driver = {
+ .name = "m10v-pinctrl",
+ .of_match_table = m10v_pmatch,
+ },
+};
+
+static int __init m10v_pinctrl_init(void)
+{
+ return platform_driver_register(&m10v_pinctrl_driver);
+}
+arch_initcall(m10v_pinctrl_init);
Can't it be builtin_platform_driver()?
I think using builtin_platform_driver() is no problem.
Which device requires this to be arch_initcall()?
This driver was originally a module, so no need to be arch_initcall().
I will use arch_initcall() instead.
Thanks
Sugaya Taichi
--
Best Regards
Masahiro Yamada
