On Fri, Jul 20, 2007 at 02:19:58PM -0700, H. Peter Anvin wrote:
> Create an inline function for clflush(), with the proper arguments,
> and use it instead of hard-coding the instruction.
>
> This also removes one instance of hard-coded wbinvd, based on a patch
> by Bauder de Oliveira Costa.
>
> Cc: Andi Kleen <[EMAIL PROTECTED]>
> Cc: Glauber de Oliveira Costa <[EMAIL PROTECTED]>
> Signed-off-by: H. Peter Anvin <[EMAIL PROTECTED]>
Mostly looks good, but see below.
> diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
> index df8da72..41f46df 100644
> --- a/drivers/char/agp/efficeon-agp.c
> +++ b/drivers/char/agp/efficeon-agp.c
> @@ -221,7 +221,7 @@ static int efficeon_create_gatt_table(struct
> agp_bridge_data *bridge)
> SetPageReserved(virt_to_page((char *)page));
>
> for (offset = 0; offset < PAGE_SIZE; offset += clflush_chunk)
> - asm volatile("clflush %0" : : "m" (*(char
> *)(page+offset)));
> + clflush((char *)page+offset);
The original code flushes (*(page+offset)) whereas the new code
flushes (pagee+offset). Assuming this is a bug-fix, it should go as a
separate patch.
> @@ -268,15 +268,16 @@ static int efficeon_insert_memory(struct agp_memory *
> mem, off_t pg_start, int t
> *page = insert;
>
> /* clflush is slow, so don't clflush until we have to */
> - if ( last_page &&
> - ((unsigned long)page^(unsigned long)last_page) &
> clflush_mask )
> - asm volatile("clflush %0" : : "m" (*last_page));
> + if (last_page &&
> + (((unsigned long)page^(unsigned long)last_page) &
> + clflush_mask))
> + clflush(last_page);
Same thing.
> last_page = page;
> }
>
> if ( last_page )
> - asm volatile("clflush %0" : : "m" (*last_page));
> + clflush(last_page);
Here too.
Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
