From: Heiner Kallweit <hkallwe...@gmail.com> Date: Sun, 9 Dec 2018 22:33:10 +0100
> On 09.12.2018 22:11, Andrew Lunn wrote: >> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: >>> Hi all, >>> >>> Commits >>> >>> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform >>> data") >>> 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for >>> phy_mask") >>> >>> are missing a Signed-off-by from their author. >> >> Hi David. >> >> Any idea what happened here? The version in my git repo has SOB. >> >> https://patchwork.ozlabs.org/patch/1009811/ also has my SOB. >> > Instead of > v2 > -- > int -> u32 in platform data structure > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > > shouldn't it be > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > --- > v2 > - int -> u32 in platform data structure No, I want the changelog to actually appear in the commit message. I'm kinda tired of saying this. Keep changelog information in the commit message, everyone. The problem here is the '--' delimiter, Andrew should have either used nothing or something else.