On 12/11/18 3:47 AM, Steve Twiss wrote:
Hi Guenter,
On 10 December 2018 22:09, Guenter Roeck wrote:
Subject: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific
SENSOR[_DEVICE]_ATTR variants
Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code,
to improve readbility, and to reduce the chance of inconsistencies.
Also replace any remaining S_<PERMS> in the driver with octal values.
The conversion was done automatically with coccinelle. The semantic patches
and the scripts used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches/hwmon/.
This patch does not introduce functional changes. It was verified by
compiling the old and new files and comparing text and data sizes.
Cc: Support Opensource <[email protected]>
Signed-off-by: Guenter Roeck <[email protected]>
---
drivers/hwmon/da9052-hwmon.c | 105 ++++++++++++++++------------------------
Thanks,
I am assuming this previous patch [01/10] hwmon: Introduce
SENSOR_DEVICE_ATTR_{RO,RW,WO} and variants
from this set, https://patchwork.kernel.org/patch/9489915/ and,
+ #define SENSOR_DEVICE_ATTR_RO(_name, _func, _index) \
+ SENSOR_DEVICE_ATTR(_name, 0444, _func##_show, NULL, _index)
Yes, of course. Sorry, I should have mentioned it.
Acked-by: Steve Twiss <[email protected]>
Thanks!
Guenter
