On Mon, Dec 17, 2018 at 11:54 PM Christoph Hellwig <h...@infradead.org> wrote:
>
> > +struct plic_hw {
> > + u32 nr_irqs;
> > + u32 nr_handlers;
> > + u32 nr_mapped;
> > + void __iomem *regs;
> > + struct irq_domain *irqdomain;
> > +};
> > +
> > +static struct plic_hw plic;
>
> Please use local variables instead of a single instance struct.
> And only add these variables in the patches where you actually need
> them.
I am sure it will be useful in-future but for now I will
remove the struct instance.
Regards,
Anup
