Hi Horia, > Horia Geanta <[email protected]> hat am 17. Dezember 2018 um 16:33 > geschrieben: > > > On 12/15/2018 11:44 PM, Stefan Wahren wrote: > > Hi, > > > >> Olof Johansson <[email protected]> hat am 13. Dezember 2018 um 07:48 > >> geschrieben: > >> > >> > >> On Fri, Nov 09, 2018 at 06:05:24AM +0000, Horia Geanta wrote: > >>> On 11/9/2018 3:11 AM, Marc Gonzalez wrote: > >>>> Commit e8342cc7954e ("enable CAAM crypto engine on QorIQ DPAA2 SoCs") > >>>> enabled CRYPTO_DEV_FSL_DPAA2_CAAM, which depends on FSL_MC_DPIO, > >>>> which is not set. Enable FSL_MC_BUS, and build FSL_MC_DPIO and > >>>> CRYPTO_DEV_FSL_DPAA2_CAAM as modules. > >>>> > >>>> Signed-off-by: Marc Gonzalez <[email protected]> > >>> Reviewed-by: Horia Geantă <[email protected]> > >> > >> I had to redo this one, and when I did I noticed that there's also an > >> ethernet > >> driver. Should that be enabled as well? > >> > > > > this patch in next-20181214 breaks "make modules_install" for > > arm64/defconfig on my Ubuntu machine: > > > > DEPMOD 4.20.0-rc6-next-20181214 > > depmod: ERROR: Found 6 modules in dependency cycles! > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio > > depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc > > -> error > > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc > > -> caamalg_desc > > > > After reverting of this patch the issue disappeared. > > > Seems there's a dependency cycle b/w dpaa2_caam and caam{alg,hash}_desc, as > follows: > > A->B > --- > dpaa2_caam needs cnstr_* exported by caam{alg,hash}_desc > > B->A > --- > caam{alg,hash}_desc need caam_imx, caam_little_end: > caam{hash,alg}_desc.c > --> desc_constr.h (included for descriptors generation functions) > --> regs.h (included for endianness helpers) > --> extern bool caam_imx, caam_little_end > caam_imx, caam_little_end are exported by dpaa2_caam - caamalg_qi2.c (when > CONFIG_CRYPTO_DEV_FSL_CAAM=n) > > Could we drop this patch, until CAAM driver gets a proper fix (which is not > straightforward)?
this issue still persists in 4.20.0-rc7-next-20181218. Could you please send a patch to revert this change? Thanks Stefan > > Thanks, > Horia > > _______________________________________________ > linux-arm-kernel mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
