On Tue, 18 Dec 2018 18:52:16 +0100, Gustavo A. R. Silva wrote: > > ipcm->substream is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > sound/pci/emu10k1/emufx.c:1031 snd_emu10k1_ipcm_poke() warn: potential > spectre issue 'emu->fx8010.pcm' [r] (local cap) > sound/pci/emu10k1/emufx.c:1075 snd_emu10k1_ipcm_peek() warn: potential > spectre issue 'emu->fx8010.pcm' [r] (local cap) > > Fix this by sanitizing ipcm->substream before using it to index > emu->fx8010.pcm > > Notice that given that speculation windows are large, the policy is > to kill the speculation on the first load and not worry if it can be > completed with a dependent load/store [1]. > > [1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2 > > Cc: [email protected] > Signed-off-by: Gustavo A. R. Silva <[email protected]>
Applied, thanks. Takashi
