On Wed, Dec 19, 2018 at 03:11:52PM +0000, Szabolcs Nagy wrote: > On 18/12/2018 12:14, Dave Martin wrote: > > On Sat, Dec 15, 2018 at 05:20:29PM +0800, kbuild test robot wrote:
[...] > >>>> ./usr/include/asm/sve_context.h:30: found __[us]{8,16,32,64} type > >>>> without #include <linux/types.h> > > > > Since the new header is not meant to be included directly (and has a > > guard to that effect), we don't strictly need to do anything here. > > > > The way to include <asm/sve_context.h> in userspace is via > > <asm/sigcontext.h> or <asm/ptrace.h>, both of which include > > <linux/types.h> first. > > > > i think there is no need to explicitly prevent the inclusion of > the header. > > it is enough to have a comment that it's not supposed to be > included by user code (so the header can be later refactored). > > and then such automated header checks (or whatever other hacks > ppl do temporarily) can continue to work. The guard is in linux-next now AFAIK. Are you saying that it's likely to break something and needs to be removed, or it is unnecessary but harmless? Cheers ---Dave