Hi Dave, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc7 next-20181220] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dave-Hansen/x86-cpu-sort-cpuinfo-flags/20181221-171144 config: x86_64-randconfig-x013-201850 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): arch/x86//kernel/cpu/proc.c: In function 'show_cpuinfo': >> arch/x86//kernel/cpu/proc.c:175:26: error: 'x86_NR_CAPS' undeclared (first >> use in this function); did you mean 'X86_NR_CAPS'? unsigned int bug_bit = x86_NR_CAPS + i; ^~~~~~~~~~~ X86_NR_CAPS arch/x86//kernel/cpu/proc.c:175:26: note: each undeclared identifier is reported only once for each function it appears in vim +175 arch/x86//kernel/cpu/proc.c 128 129 static int show_cpuinfo(struct seq_file *m, void *v) 130 { 131 struct cpuinfo_x86 *c = v; 132 unsigned int cpu; 133 int i; 134 135 cpu = c->cpu_index; 136 seq_printf(m, "processor\t: %u\n" 137 "vendor_id\t: %s\n" 138 "cpu family\t: %d\n" 139 "model\t\t: %u\n" 140 "model name\t: %s\n", 141 cpu, 142 c->x86_vendor_id[0] ? c->x86_vendor_id : "unknown", 143 c->x86, 144 c->x86_model, 145 c->x86_model_id[0] ? c->x86_model_id : "unknown"); 146 147 if (c->x86_stepping || c->cpuid_level >= 0) 148 seq_printf(m, "stepping\t: %d\n", c->x86_stepping); 149 else 150 seq_puts(m, "stepping\t: unknown\n"); 151 if (c->microcode) 152 seq_printf(m, "microcode\t: 0x%x\n", c->microcode); 153 154 if (cpu_has(c, X86_FEATURE_TSC)) { 155 unsigned int freq = aperfmperf_get_khz(cpu); 156 157 if (!freq) 158 freq = cpufreq_quick_get(cpu); 159 if (!freq) 160 freq = cpu_khz; 161 seq_printf(m, "cpu MHz\t\t: %u.%03u\n", 162 freq / 1000, (freq % 1000)); 163 } 164 165 /* Cache size */ 166 if (c->x86_cache_size) 167 seq_printf(m, "cache size\t: %u KB\n", c->x86_cache_size); 168 169 show_cpuinfo_core(m, c, cpu); 170 show_cpuinfo_misc(m, c); 171 show_cpuinfo_flags(m, c); 172 173 seq_puts(m, "\nbugs\t\t:"); 174 for (i = 0; i < 32*NBUGINTS; i++) { > 175 unsigned int bug_bit = x86_NR_CAPS + i; 176 177 if (cpu_has_bug(c, bug_bit) && x86_bug_flags[i]) 178 seq_printf(m, " %s", x86_bug_flags[i]); 179 } 180 181 seq_printf(m, "\nbogomips\t: %lu.%02lu\n", 182 c->loops_per_jiffy/(500000/HZ), 183 (c->loops_per_jiffy/(5000/HZ)) % 100); 184 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
