On Fri, 2018-12-21 at 19:06 -0500, Steven Rostedt wrote: > On Fri, 21 Dec 2018 18:13:16 -0500 > Steven Rostedt <[email protected]> wrote: > > > +static __always_inline int str_has_prefix(const char *str, const char > > *prefix) > > I'm thinking it is cleaner to have two helper functions and have them > both return bool. > > static __always_inline bool str_has_prefix(const char *str, const char > *prefix) > { > return !strncmp(str, prefix, strlen(prefix)); > } > > ( I still like to keep the __always_inline, it doesn't hurt ) > > And I'll make a separate patch that adds: > > static __always_inline bool > str_has_prefix_len(const char *str, const char *prefix, unsigned int *len) > { > *len = strlen(prefix); > return !strncmp(str, prefix, *len) ? *len : 0; > } > > Everyone OK with that?
I guess so as you're the one doing all the work. Trivia: Shouldn't the latter function use __kernel_size_t as that's the actual return type of strlen? Thanks for keeping at it.
