Hi Yangtao, On mer., déc. 26 2018, Yangtao Li <[email protected]> wrote:
> The of_find_compatible_node() returns a node pointer with refcount > incremented, but there is the lack of use of the of_node_put() when > done. Add the missing of_node_put() to release the refcount. Reviewed-by: Gregory CLEMENT <[email protected]> Thanks, Gregory > > Signed-off-by: Yangtao Li <[email protected]> > --- > drivers/clk/mvebu/armada-370.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c > index 7dedfaa6e152..5c6bbee396b3 100644 > --- a/drivers/clk/mvebu/armada-370.c > +++ b/drivers/clk/mvebu/armada-370.c > @@ -175,8 +175,10 @@ static void __init a370_clk_init(struct device_node *np) > > mvebu_coreclk_setup(np, &a370_coreclks); > > - if (cgnp) > + if (cgnp) { > mvebu_clk_gating_setup(cgnp, a370_gating_desc); > + of_node_put(cgnp); > + } > } > CLK_OF_DECLARE(a370_clk, "marvell,armada-370-core-clock", a370_clk_init); > > -- > 2.17.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
