Hi Yangtao, On mer., déc. 26 2018, Yangtao Li <[email protected]> wrote:
> The of_find_compatible_node() returns a node pointer with refcount > incremented, but there is the lack of use of the of_node_put() when > done. Add the missing of_node_put() to release the refcount. Reviewed-by: Gregory CLEMENT <[email protected]> Thanks, Gregory > > Signed-off-by: Yangtao Li <[email protected]> > --- > drivers/clk/mvebu/mv98dx3236.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/mvebu/mv98dx3236.c b/drivers/clk/mvebu/mv98dx3236.c > index 0a74cf7a7725..1c8ab4f834ba 100644 > --- a/drivers/clk/mvebu/mv98dx3236.c > +++ b/drivers/clk/mvebu/mv98dx3236.c > @@ -172,7 +172,9 @@ static void __init mv98dx3236_clk_init(struct device_node > *np) > > mvebu_coreclk_setup(np, &mv98dx3236_core_clocks); > > - if (cgnp) > + if (cgnp) { > mvebu_clk_gating_setup(cgnp, mv98dx3236_gating_desc); > + of_node_put(cgnp); > + } > } > CLK_OF_DECLARE(mv98dx3236_clk, "marvell,mv98dx3236-core-clock", > mv98dx3236_clk_init); > -- > 2.17.0 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
