From: Heiner Kallweit <hkallwe...@gmail.com> Date: Wed, 26 Dec 2018 20:13:15 +0100
> On 26.12.2018 19:21, Kangjie Lu wrote: >> Both bcm_sf2_sw_indir_rw and mdiobus_write_nested could fail, so let's >> return their error codes upstream. >> >> Signed-off-by: Kangjie Lu <k...@umn.edu> >> --- >> drivers/net/dsa/bcm_sf2.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c >> index 2eb68769562c..236815700fba 100644 >> --- a/drivers/net/dsa/bcm_sf2.c >> +++ b/drivers/net/dsa/bcm_sf2.c >> @@ -303,11 +303,10 @@ static int bcm_sf2_sw_mdio_write(struct mii_bus *bus, >> int addr, int regnum, >> * send them to our master MDIO bus controller >> */ >> if (addr == BRCM_PSEUDO_PHY_ADDR && priv->indir_phy_mask & BIT(addr)) >> - bcm_sf2_sw_indir_rw(priv, 0, addr, regnum, val); >> + return bcm_sf2_sw_indir_rw(priv, 0, addr, regnum, val); > This is wrong. Please get familiar with what the function does. > And test changes before submitting them! This is getting rediculous. You are making completely untested changes, resubmitting very quickly without any care or consideration whatsoever, and wasting a lot of developer time with your carelessness. Please stop doing this.
