Greg Kroah-Hartman <[email protected]> writes:
> We are trying to get rid of BUS_ATTR() and the usage of that in
> ibmebus.c can be trivially converted to use BUS_ATTR_WO(), so use that
> instead.
>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Tyrel Datwyler <[email protected]>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
>  arch/powerpc/platforms/pseries/ibmebus.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

LGTM.

Acked-by: Michael Ellerman <[email protected]> (powerpc)

cheers

> diff --git a/arch/powerpc/platforms/pseries/ibmebus.c 
> b/arch/powerpc/platforms/pseries/ibmebus.c
> index 5b4a56131904..84e8ec4011ba 100644
> --- a/arch/powerpc/platforms/pseries/ibmebus.c
> +++ b/arch/powerpc/platforms/pseries/ibmebus.c
> @@ -261,8 +261,7 @@ static char *ibmebus_chomp(const char *in, size_t count)
>       return out;
>  }
>  
> -static ssize_t ibmebus_store_probe(struct bus_type *bus,
> -                                const char *buf, size_t count)
> +static ssize_t probe_store(struct bus_type *bus, const char *buf, size_t 
> count)
>  {
>       struct device_node *dn = NULL;
>       struct device *dev;
> @@ -298,10 +297,9 @@ static ssize_t ibmebus_store_probe(struct bus_type *bus,
>               return rc;
>       return count;
>  }
> -static BUS_ATTR(probe, 0200, NULL, ibmebus_store_probe);
> +static BUS_ATTR_WO(probe);
>  
> -static ssize_t ibmebus_store_remove(struct bus_type *bus,
> -                                 const char *buf, size_t count)
> +static ssize_t remove_store(struct bus_type *bus, const char *buf, size_t 
> count)
>  {
>       struct device *dev;
>       char *path;
> @@ -325,7 +323,7 @@ static ssize_t ibmebus_store_remove(struct bus_type *bus,
>               return -ENODEV;
>       }
>  }
> -static BUS_ATTR(remove, 0200, NULL, ibmebus_store_remove);
> +static BUS_ATTR_WO(remove);
>  
>  static struct attribute *ibmbus_bus_attrs[] = {
>       &bus_attr_probe.attr,
> -- 
> 2.20.1

Reply via email to