On Fri, Dec 28, 2018 at 09:48:34AM +0100, Christoph Hellwig wrote: > On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > > Follow the kernel conventions, rename addr_in_gen_pool to > > gen_pool_has_addr. > > Which convention? The old name certainly looks more sensible to me. I submitted a patch to export the symbol, addr_in_gen_pool. But most the exported symbols are named like gen_pool_*.
What about I add a macro in the header genalloc.h, such as: #define addr_in_gen_pool gen_pool_has_addr > > If we really want to change anything about this function I'd suggest > to drop the size argument, as the address itself should describe the > region good enough. Maybe others need the @size argument. I am not sure if it is right to remove the size argument... Thanks Huang Shijie
