Re: [PATCH v5 04/15] KVM: s390: use pending_irqs_no_gisa() where appropriate

[Pierre Morel]

On 19/12/2018 20:17, Michael Mueller wrote:

Interruption types that are not represented in GISA shall
use pending_irqs_no_gisa() to test pending interruptions.

Signed-off-by: Michael Mueller <m...@linux.ibm.com>
---
  arch/s390/kvm/interrupt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index c3a8b2fbbcf2..093b568b6356 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -353,7 +353,7 @@ static void set_intercept_indicators_io(struct kvm_vcpu 
*vcpu)

static void set_intercept_indicators_ext(struct kvm_vcpu *vcpu)

  {
-       if (!(pending_irqs(vcpu) & IRQ_PEND_EXT_MASK))
+       if (!(pending_irqs_no_gisa(vcpu) & IRQ_PEND_EXT_MASK))
                return;
        if (psw_extint_disabled(vcpu))
                kvm_s390_set_cpuflags(vcpu, CPUSTAT_EXT_INT);
@@ -363,7 +363,7 @@ static void set_intercept_indicators_ext(struct kvm_vcpu 
*vcpu)

static void set_intercept_indicators_mchk(struct kvm_vcpu *vcpu)

  {
-       if (!(pending_irqs(vcpu) & IRQ_PEND_MCHK_MASK))
+       if (!(pending_irqs_no_gisa(vcpu) & IRQ_PEND_MCHK_MASK))
                return;
        if (psw_mchk_disabled(vcpu))
                vcpu->arch.sie_block->ictl |= ICTL_LPSW;

Reviewed-by: Pierre Morel<pmo...@linux.ibm.com>


--
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany