On Fri, Dec 28, 2018 at 02:36:23PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575...@notesmail.huawei.com>
> 
> Signed-off-by: John Stultz <john.stu...@linaro.org>
> Signed-off-by: Youlin Wang <wwx575...@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantang...@huawei.com>
> Cc: Wei Xu <xuw...@hisilicon.com>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> ---
>  arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi 
> b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> index f432b0a..5223e36 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
> @@ -1122,5 +1122,19 @@
>                               };
>                       };
>               };
> +
> +             asp_dmac: asp_dmac@E804B000 {

dma-controller@e804b000

> +                     compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> +                     reg = <0x0 0xe804b000 0x0 0x1000>;
> +                     #dma-cells = <1>;
> +                     dma-channels = <16>;
> +                     dma-requests = <32>;
> +                     dma-min-chan = <0>;
> +                     dma-used-chans = <0xFFFE>;

Use lowercase hex.

But more importantly, as John mentioned, this and other properties 
aren't documented.

> +                     dma-share;
> +                     interrupts = <0 216 4>;
> +                     interrupt-names = "asp_dma_irq";
> +                     status = "ok";

Don't need this.

> +             };
>       };
>  };
> -- 
> 1.9.1
> 

Reply via email to