On Sun, Jul 29, 2007 at 09:03:29PM +0800, Eugene Teo wrote: > Neil Horman wrote: > [...] > > + /* core limit size */ > > + case 'c': > > + rc = snprintf(out_ptr, out_end - out_ptr, > > + "%lu", > > current->signal->rlim[RLIMIT_CORE].rlim_cur); > > Trailing space. > > [...] > > - if(call_usermodehelper_pipe(corename+1, NULL, NULL, &file)) { > > + if(call_usermodehelper_pipe(corename+1, helper_argv, NULL, > > &file)) { > ^^^^^^^^^^^^^ > > Use tabs, and a missing space after '('. > I think your reader is screwing up the patch. The version that I sent, which I have here, shows that as all tabs, no spaces.
As for the '(', yeah, that looks like its been there for awhile. I'll clean it all up when I address macro expansion, as per the conversation Martin and I have been holding. Regards Neil > Eugene -- /*************************************************** *Neil Horman *Software Engineer *Red Hat, Inc. [EMAIL PROTECTED] *gpg keyid: 1024D / 0x92A74FA1 *http://pgp.mit.edu ***************************************************/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/