On Thu, Jan 10, 2019 at 12:39 PM Tetsuo Handa <[email protected]> wrote: > On 2019/01/02 5:28, Paul Fulghum wrote: > > Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call > > while current is TASK_INTERRUPTIBLE. > > This is a false positive since the code path does not depend on current > > state remaining TASK_INTERRUPTIBLE. > > The loop breaks out and sets TASK_RUNNING after calling copy_to_user. > > This patch supresses the warning by setting TASK_RUNNING before calling > > copy_to_user. > > > > [1] > > https://syzkaller.appspot.com/bug?id=17d5de7f1fcab794cb8c40032f893f52de899324 > > > > Signed-off-by: Paul Fulghum <[email protected]> > > Reported-by: syzbot <[email protected]> > > Cc: Greg Kroah-Hartman <[email protected]> > > Cc: Tetsuo Handa <[email protected]> > > Cc: Arnd Bergmann <[email protected]> > > Cc: Alan Cox <[email protected]>
This version looks good to me. Acked-by: Arnd Bergmann <[email protected]> Arnd
