Hi, On Mon, Jan 14, 2019 at 11:20:49AM +0100, Linus Walleij wrote: > Hi Jonathan, > > thanks for the patch! It is looking very good. > Some minor comments: > > On Sun, Jan 13, 2019 at 3:00 PM Jonathan Neuschäfer [...] > > + spin_lock_irqsave(&hlwd->gpioc.bgpio_lock, flags); > > + pending = hlwd->gpioc.read_reg(hlwd->regs + HW_GPIOB_INTFLAG); > > + pending &= hlwd->gpioc.read_reg(hlwd->regs + HW_GPIOB_INTMASK); > > Please just access IO directly instead through the helper. > ioread32be()/iowrite32be() I suppose?
Ok. Yes, 32-bit big endian is correct. [...] > > + hlwd->irqc.name = "GPIO"; > > What about using something device-unique? > > hlwd->irqc.name = dev_name(&pdev->dev); > > for example? Good idea, especially considering that the Wii U (the successor of the Wii) has two of these GPIO controllers. > otherwise it looks fine! Cool, I'll send a v2 with these two points addressed. Thanks, Jonathan Neuschäfer
signature.asc
Description: PGP signature
