On Thu, Dec 20, 2018 at 01:14:46PM +0800, Peng Hao wrote: > Return 0 for empty body register function normally. > > Signed-off-by: Peng Hao <[email protected]> > --- > v4 --> v5 : resolve kbuild issue: handle all typo "drvier/driver" > in funtion name. > > v3 --> v4 : use pcim* function instead of pci* function. > handle typo "drvier/driver" in funtion name. > > v2 --> v3 : resolve kbuild issue : a uninitialized variable in some path. > > v2 --> v1 : resolve kbuild issue : arch=sh don't support pci, adjust > CONFIG_PCI macro. > > v1 : QEMU community requires additional PCI devices to simulate PVPANIC > devices > so that some architectures can not occupy precious less than 4G of memory > space. > > drivers/misc/pvpanic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c > index 3150dc2..f84ed30 100644 > --- a/drivers/misc/pvpanic.c > +++ b/drivers/misc/pvpanic.c > @@ -125,7 +125,7 @@ static void pvpanic_unregister_acpi_driver(void) > #else > static int pvpanic_register_acpi_driver(void) > { > - return -ENODEV; > + return 0;
No, you want -ENODEV as this can only happen if acpi is enabled, and you are on an kernel without acpi. But, that can not happen, as if CONFIG_ACPI is not set, then acpi_disabled is always set to 1, and then this can never be called. So I don't see why this needs to be changed at all. thanks, greg k-h
