On Fri, Jan 18, 2019 at 02:32:58AM +0530, Jeffrin Jose T wrote: > The kmod.sh script breaks
First thanks for the patch! But now let's get to it: on what distribution and version of bash does this break? The commit log should refer to this and it would help me confirm the issue. > because an array is passed Which is the array? > as input > instead of a single element input.This patch takes elements > one at a time and passed as input to the condition statement > which in turn fixes the error.There was an issue which had > the need for passing a single digit to the condition statement > which is fixed using regular expression. > > Signed-off-by: Jeffrin Jose T <[email protected]> > --- > tools/testing/selftests/kmod/kmod.sh | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/kmod/kmod.sh > b/tools/testing/selftests/kmod/kmod.sh > index 0a76314b4414..49b273c3646e 100755 > --- a/tools/testing/selftests/kmod/kmod.sh > +++ b/tools/testing/selftests/kmod/kmod.sh > @@ -526,9 +526,12 @@ function run_all_tests() > TEST_ID=${i%:*:*} > ENABLED=$(get_test_enabled $TEST_ID) > TEST_COUNT=$(get_test_count $TEST_ID) > - if [[ $ENABLED -eq "1" ]]; then > - test_case $TEST_ID $TEST_COUNT > - fi get_test_enabled() is supposed to do what you do open-handed here. So the better question is why are you getting an array returned for your version of bash. > + for j in $ENABLED ; do > + CHECK=${j#*:*:} > + if [[ $CHECK -eq "1" ]]; then > + test_case $TEST_ID $TEST_COUNT > + fi > + done > done > } > > -- > 2.20.1 Luis
