On Wed, Jan 23, 2019 at 02:22:33PM +0100, Peter Oberparleiter wrote: > On 22.01.2019 16:21, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Also delete the dentry variable as it is never needed. > > > > Cc: Peter Oberparleiter <[email protected]> > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > --- > > kernel/gcov/fs.c | 22 ++-------------------- > > 1 file changed, 2 insertions(+), 20 deletions(-) > > Acked-by: Peter Oberparleiter <[email protected]> > > Compile test was successful, but the patch introduces a compile warning. > Could you merge the attached patch? > > 8<=== > From: Peter Oberparleiter <[email protected]> > Subject: [PATCH] gcov: Fix compiler warning > > Fix compiler warning when compiling with CONFIG_GCOV_KERNEL=y: > > CC kernel/gcov/fs.o > kernel/gcov/fs.c: In function ‘gcov_fs_init’: > kernel/gcov/fs.c:756:6: warning: unused variable ‘rc’ [-Wunused-variable] > int rc = -EIO; > ^~ > > Signed-off-by: Peter Oberparleiter <[email protected]> > --- > kernel/gcov/fs.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c > index aa9a49f72024..e5eb5ea7ea59 100644 > --- a/kernel/gcov/fs.c > +++ b/kernel/gcov/fs.c > @@ -753,8 +753,6 @@ void gcov_event(enum gcov_action action, struct gcov_info > *info) > /* Create debugfs entries. */ > static __init int gcov_fs_init(void) > { > - int rc = -EIO; > - > init_node(&root_node, NULL, NULL, NULL); > /* > * /sys/kernel/debug/gcov will be parent for the reset control file > --
Ah, good catch, will do that, thanks. greg k-h
