Sorry for late response.
But, this patch is the cause of compile error of memory unplug code of
2.6.23-rc1-mm2. It uses putback_lru_pages().
Don't make it static please... :-(
Bye.
----
CC mm/memory_hotplug.o
mm/memory_hotplug.c: In function ‘do_migrate_range’:
mm/memory_hotplug.c:402: error: implicit declaration of function
‘putback_lru_pages’
make[1]: *** [mm/memory_hotplug.o] Error 1
----
> This patch contains the following cleanups:
> - every file should include the headers containing the prototypes for
> its global functions
> - make the needlessly global putback_lru_pages() static
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
> Acked-by: Christoph Lameter <[EMAIL PROTECTED]>
>
> ---
>
> This patch has been sent on:
> - 6 Jul 2007
>
> include/linux/migrate.h | 2 --
> mm/migrate.c | 3 ++-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> --- linux-2.6.22-rc6-mm1/include/linux/migrate.h.old 2007-07-05
> 17:10:01.000000000 +0200
> +++ linux-2.6.22-rc6-mm1/include/linux/migrate.h 2007-07-05
> 17:10:10.000000000 +0200
> @@ -26,7 +26,6 @@
> }
>
> extern int isolate_lru_page(struct page *p, struct list_head *pagelist);
> -extern int putback_lru_pages(struct list_head *l);
> extern int migrate_page(struct address_space *,
> struct page *, struct page *);
> extern int migrate_pages(struct list_head *l, new_page_t x, unsigned long);
> @@ -44,7 +43,6 @@
>
> static inline int isolate_lru_page(struct page *p, struct list_head *list)
> { return -ENOSYS; }
> -static inline int putback_lru_pages(struct list_head *l) { return 0; }
> static inline int migrate_pages(struct list_head *l, new_page_t x,
> unsigned long private) { return -ENOSYS; }
>
> --- linux-2.6.22-rc6-mm1/mm/migrate.c.old 2007-07-05 17:10:16.000000000
> +0200
> +++ linux-2.6.22-rc6-mm1/mm/migrate.c 2007-07-05 17:11:43.000000000 +0200
> @@ -28,6 +28,7 @@
> #include <linux/mempolicy.h>
> #include <linux/vmalloc.h>
> #include <linux/security.h>
> +#include <linux/syscalls.h>
>
> #include "internal.h"
>
> @@ -101,7 +102,7 @@
> *
> * returns the number of pages put back.
> */
> -int putback_lru_pages(struct list_head *l)
> +static int putback_lru_pages(struct list_head *l)
> {
> struct page *page;
> struct page *page2;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Yasunori Goto
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
