> From: yuehaibing > Sent: Friday, January 25, 2019 3:14 AM > To: [email protected]; Zhuangyuzeng (Yisen) <[email protected]>; > Salil Mehta <[email protected]>; lipeng (Y) <[email protected]> > Cc: [email protected]; [email protected]; yuehaibing > <[email protected]> > Subject: [PATCH net-next] net: hns3: Fix potential NULL dereference on > allocation error > > hclge_mac_update_stats_complete doesn't check for NULL > returns of kcalloc, it may result in an Oops. > > Fixes: d174ea75c96a ("net: hns3: add statistics for PFC frames and MAC > control frames") > Signed-off-by: YueHaibing <[email protected]> > --- > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > index 64b1589..7971606 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c > @@ -343,6 +343,9 @@ static int hclge_mac_update_stats_complete(struct > hclge_dev *hdev, u32 desc_num) > int ret; > > desc = kcalloc(desc_num, sizeof(struct hclge_desc), GFP_KERNEL); > + if (!desc) > + return -ENOMEM; > +
looks good to me. Reviewed-by: Salil Mehta <[email protected]>
