On 29.01.19 07:57, Yogesh Narayan Gaur wrote: > Hi, > >> -----Original Message----- >> From: Stephen Rothwell [mailto:[email protected]] >> Sent: Tuesday, January 29, 2019 7:33 AM >> To: Mark Brown <[email protected]> >> Cc: Linux Next Mailing List <[email protected]>; Linux Kernel >> Mailing >> List <[email protected]>; Yogesh Narayan Gaur >> <[email protected]>; Frieder Schrempf >> <[email protected]>; Boris Brezillon <[email protected]>; >> Ashish Kumar <[email protected]> >> Subject: linux-next: build warning after merge of the spi tree >> >> Hi all, >> >> After merging the spi tree, today's linux-next build (KCONFIG_NAME) produced >> this warning: >> >> WARNING: modpost: missing MODULE_LICENSE() in drivers/spi/spi-nxp-fspi.o >> see include/linux/module.h for more information >> > Can someone help in pointing out that why above warning message is coming for > mentioned commit. > Below MODULE_LICENSE string is present in the above mentioned file, > drivers/spi/spi-nxp-fspi.c. > MODULE_LICENSE("GPL v2");
No, it is not present. Look at your patches [1] or at spi-next [2]. MODULE_LICENSE is definitely missing. In patchwork the missing line was appended to the commit message instead of the actual patch for some reason. [1] https://patchwork.kernel.org/patch/10764347/ [2] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-next&id=a5356aef6a907c2e2aed0caaa2b88b6021394471
