The percpu member of this structure is declared as:
        struct ... ** __percpu member;
So its type is:
        __percpu pointer to pointer to struct ...

But looking at how it's used, its type should be:
        pointer to __percpu pointer to struct ...
and it should thus be declared as:
        struct ... * __percpu *member;

So fix the placement of '__percpu' in the definition of this
structures.

This silents a few Sparse's warnings like:
        warning: incorrect type in initializer (different address spaces)
          expected void const [noderef] <asn:3> *__vpp_verify
          got struct sched_domain **

CC: Jens Axboe <[email protected]>
CC: Andrew Morton <[email protected]>
CC: Thomas Gleixner <[email protected]>
CC: [email protected]
Fixes: 017c59c042d0 ("relay: Use per CPU constructs for the relay channel 
buffer pointers")
Signed-off-by: Luc Van Oostenryck <[email protected]>

---
Changes since v1:
* use core.abbrev = auto for 'Fixes: 017c59c04...'
* remove bouncing email address

---
 include/linux/relay.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/relay.h b/include/linux/relay.h
index e1bdf01a86e2..c759f96e39c1 100644
--- a/include/linux/relay.h
+++ b/include/linux/relay.h
@@ -66,7 +66,7 @@ struct rchan
        struct kref kref;               /* channel refcount */
        void *private_data;             /* for user-defined data */
        size_t last_toobig;             /* tried to log event > subbuf size */
-       struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */
+       struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */
        int is_global;                  /* One global buffer ? */
        struct list_head list;          /* for channel list */
        struct dentry *parent;          /* parent dentry passed to open */
-- 
2.20.0

Reply via email to