Hi, On Wed, Jan 30, 2019 at 4:40 PM Bjorn Andersson <[email protected]> wrote: > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index d19486ba1e5e..07d9cd6fba7d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -325,6 +325,64 @@ > }; > }; > > + adsp_pas: remoteproc-adsp { > + compatible = "qcom,sdm845-adsp-pas";
After discussion with you offline I now understand why this is using "-pas" and not "-pil". ...and I understand that on my particular board (which should use "-pil") we'll juse leave this as status = "disabled". It would be good if something in this series updated the bindings to make it clearer since I can't find anything in these two files: Documentation/devicetree/bindings/remoteproc/qcom,adsp-pil.txt Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt ...explain when the "-pil" is used and when the "-pas" is used. -Doug
