Hi, On 03/02/2019 06:41, wen yang wrote: > The call to of_parse_phandle returns a node pointer with refcount > incremented thus it must be explicitly decremented here after the last > usage. >
Missing a Fixes tag. > Signed-off-by: Wen Yang <[email protected]> > Cc: Kevin Hilman <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > drivers/soc/amlogic/meson-canvas.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/amlogic/meson-canvas.c > b/drivers/soc/amlogic/meson-canvas.c > index fce33ca..87a6c6e 100644 > --- a/drivers/soc/amlogic/meson-canvas.c > +++ b/drivers/soc/amlogic/meson-canvas.c > @@ -57,9 +57,12 @@ struct meson_canvas *meson_canvas_get(struct device *dev) > return ERR_PTR(-ENODEV); > > canvas_pdev = of_find_device_by_node(canvas_node); > - if (!canvas_pdev) > + if (!canvas_pdev) { > + of_node_put(canvas_node); > return ERR_PTR(-EPROBE_DEFER); > + } > > + of_node_put(canvas_node); > return dev_get_drvdata(&canvas_pdev->dev); > } > EXPORT_SYMBOL_GPL(meson_canvas_get); > Apart the missing Fixes tag : Reviewed-by: Neil Armstrong <[email protected]> Neil
