Move the code from the long pointer() function. We are going to improve
error handling that will make it more complicated.

This patch does not change the existing behavior.

Signed-off-by: Petr Mladek <[email protected]>
---
 lib/vsprintf.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index d8bc3bb8ce18..9621b76f6c60 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1519,6 +1519,17 @@ char *escaped_string(char *buf, char *end, u8 *addr, 
struct printf_spec spec,
        return buf;
 }
 
+static char *va_format(char *buf, char *end, struct va_format *va_fmt)
+{
+       va_list va;
+
+       va_copy(va, *va_fmt->va);
+       buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
+       va_end(va);
+
+       return buf;
+}
+
 static noinline_for_stack
 char *uuid_string(char *buf, char *end, const u8 *addr,
                  struct printf_spec spec, const char *fmt)
@@ -2046,15 +2057,7 @@ char *pointer(const char *fmt, char *buf, char *end, 
void *ptr,
        case 'U':
                return uuid_string(buf, end, ptr, spec, fmt);
        case 'V':
-               {
-                       va_list va;
-
-                       va_copy(va, *((struct va_format *)ptr)->va);
-                       buf += vsnprintf(buf, end > buf ? end - buf : 0,
-                                        ((struct va_format *)ptr)->fmt, va);
-                       va_end(va);
-                       return buf;
-               }
+               return va_format(buf, end, ptr);
        case 'K':
                return restricted_pointer(buf, end, ptr, spec);
        case 'N':
-- 
2.13.7

Reply via email to