Re: [PATCH 1/2] parport: daisy: use new parport device model

[Greg Kroah-Hartman]

On Sat, Feb 09, 2019 at 08:59:06PM +0000, Sudip Mukherjee wrote:
> -     return bus_register(&parport_bus_type);
> +     int retval;
> +
> +     retval = bus_register(&parport_bus_type);
> +     if (retval)
> +             return retval;
> +#ifdef CONFIG_PARPORT_1284
> +     daisy_drv_init();
> +#endif

Shouldn't you hide these #ifdef lines in the .h file instead of putting
them in the .c file?

thanks,

greg k-h