On Tue, 12 Feb 2019 15:08:03 -0600
"Gustavo A. R. Silva" <[email protected]> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> kernel/trace/trace_events_filter.c: In function ‘predicate_parse’:
> kernel/trace/trace_events_filter.c:494:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> if (next[1] == next[0]) {
> ^
> kernel/trace/trace_events_filter.c:498:4: note: here
> default:
> ^~~~~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
Thanks, but I've already applied this patch:
http://lkml.kernel.org/r/[email protected]
I just haven't run my queue through my tests to push it to linux-next
yet.
-- Steve
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> kernel/trace/trace_events_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/trace_events_filter.c
> b/kernel/trace/trace_events_filter.c
> index 27821480105e..eb694756c4bb 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c
> @@ -495,6 +495,7 @@ predicate_parse(const char *str, int nr_parens, int
> nr_preds,
> ptr++;
> break;
> }
> + /* fall through */
> default:
> parse_error(pe, FILT_ERR_TOO_MANY_PREDS,
> next - str);
