On Thu, Feb 14, 2019 at 09:06:20AM -0500, Steven Rostedt wrote:
> Although you did say above that "patch" is an overloaded term. Also, I
> do find the current name rather descriptive.

When you look at "text_to_poke" as a struct name, you go, WTF is that?
The whole text? Some of it?

It should have the word "location" in it, to be clearer IMO.

>       void *trampoline;

Well, it ain't a trampoline either. It is a "temporary location to go to while
patching is going on". Now make that a member name!

:-)))

> But they are named after you! "bp_" :-)

Uuh, you shouldn't have! :-)

Then they *must* be changed immediately!

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Reply via email to