On Wed, Feb 20, 2019 at 04:58:49PM +0800, Chen-Yu Tsai wrote: > On Sun, Feb 17, 2019 at 2:21 AM Mans Rullgard <[email protected]> wrote: > > > > This adds pinctrl settings for various missing uart options. > > > > Signed-off-by: Mans Rullgard <[email protected]> > > --- > > arch/arm/boot/dts/sun7i-a20.dtsi | 45 ++++++++++++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi > > b/arch/arm/boot/dts/sun7i-a20.dtsi > > index af5b067a5f83..2295ff5adf48 100644 > > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > > @@ -944,6 +944,31 @@ > > function = "uart0"; > > }; > > > > + uart0_pf_pins: uart0-pf-pins { > > + pins = "PF2", "PF4"; > > + function = "uart0"; > > + }; > > We've had the policy of not adding pinctrl nodes that aren't used in-tree, > to avoid bloating up the blob size. However DTC 1.4.7 introduced the new > /omit-if-no-ref/ directive, which would make the compiler discard marked > nodes if they aren't referenced. > > So please add this to all the new nodes. It seems to work regardless whether > you add it before or after the label, though having it after the label seems > to make vim syntax highlighting happier.
It also works (both for dtc and vim) if we put it on the previous
line, so something like:
/omit-if-no-ref/
uart0_pf_pins: uart0-pf-pins {
};
And it does have the advantage of keeping the same line width, which
could get pretty long on some nodes.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
signature.asc
Description: PGP signature
