On Sun, Feb 24, 2019 at 09:17:10AM +0100, Greg KH wrote: > On Sat, Feb 23, 2019 at 10:55:33AM -0500, Sasha Levin wrote: > > On Sat, Feb 23, 2019 at 09:57:15AM +0100, Greg KH wrote: > > > On Fri, Feb 22, 2019 at 10:12:25PM -0500, Sasha Levin wrote: > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > > Hash: SHA512 > > > > > > > > The following changes since commit > > > > 8834f5600cf3c8db365e18a3d5cac2c2780c81e5: > > > > > > > > Linux 5.0-rc5 (2019-02-03 13:48:04 -0800) > > > > > > > > are available in the Git repository at: > > > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git > > > > tags/hyperv-fixes-signed > > > > > > > > for you to fetch changes up to b2946cd86f3c1b5b1262c0ec06068110c2328fe6: > > > > > > > > MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS > > > > (2019-02-22 21:46:37 -0500) > > > > > > > > - ---------------------------------------------------------------- > > > > Two fixes: > > > > > > > > 1. A fix for a race condition reading sysfs entries while a device is > > > > being added, by Kimberly Brown. > > > > > > > > 2. Update the Hyper-V mailing list to a new one created on > > > > vger.kernel.org, by Haiyang Zhang. > > > > > > > > - ---------------------------------------------------------------- > > > > Haiyang Zhang (1): > > > > MAINTAINERS: Change mailing list for Hyper-V CORE AND DRIVERS > > > > > > > > Kimberly Brown (2): > > > > Drivers: hv: vmbus: Change server monitor_pages index to 0 > > > > Drivers: hv: vmbus: Return -EINVAL if monitor_allocated not set > > > > > > I objected to this last patch when it was posted on the list. The sysfs > > > file should just not be present if the functionality is not there, no > > > need to add the "-EINVAL" logic to it instead. > > > > > > Having a sysfs file that says it can be read, and then rejecting that > > > read with an error is NOT ok. > > > > Hm, I'm sorry but I didn't see an objection on the thread > > (https://lore.kernel.org/lkml/20190122020759.GA4054@ubu-Virtual-Machine/) > > which is why it was sent in like this. > > > > Could you please point me to it so we can get the patch fixed up? > > My response was Message-ID: <[email protected]> sent: > Date: Tue, 19 Feb 2019 07:17:48 +0100 > but for some reason I do not see it on lore.kernel.org at all :( > > I don't know what happened to it, sorry, it was also cc: to you. > > Anyway, it just said what I said here, don't do this type of thing, if > the sysfs file is not valid for a specific device, just do not create > it, do not mess around with returning error values when trying to read > from it. >
I didn't receive that email either. Thanks for the feedback. I'll start looking into a new fix for this. Kim > thanks, > > greg k-h
