On Fri, Mar 01, 2019 at 10:45:02PM +0800, Baoquan He wrote: > Hi Kirill, > > I updated patch per your comments. While I kept the 'paddr' variable and > the '0' initilization stuffs. My thought is there are two kinds of mapping > in the handling, so keeping these names from old codes can make it more > understandable. What do you think? > > Kind Physical address Virtual address > ---------------------------------------------------------------- > Direct mapping paddr vaddr = paddr+PAGE_OFFSET > 1:1 mapping paddr paddr
I agree with your logic and patch looks good to me. But maybe you should exmplain this in the comments too? Anyway: Acked-by: Kirill A. Shutemov <[email protected]> -- Kirill A. Shutemov
