On 03/06/19 at 04:48pm, Kairui Song wrote: > On Tue, Feb 19, 2019 at 4:00 PM Kairui Song <[email protected]> wrote: > Hi Baoquan, after second thought, vmcore and kcore are doing similar > thing but still quite independent of each, didn't see any simple way > to share the logic. > And for the following naming issue I think considering the context > there is no problem, "exclude_from_vmcore(aper_alloc, aper_order)" is > clearly doing what it literally means, excluding the aperture from > vmcore. > > Let me know if anything is wrong, will send V4 later reuse this approach.
Thanks for the effort. Yes, saw your v3. I kept quiet because I personally prefer the v2 method which is similar to vmcore handling. So if you have investigated and decided to do v2 way after deliberate thought, feel free to post v4. I will make time to review. Thanks Baoquan
