On Wed, Mar 6, 2019 at 9:42 PM Oded Gabbay <[email protected]> wrote: > > On Thu, Mar 7, 2019 at 5:46 AM Kees Cook <[email protected]> wrote: > > > > On Sat, Mar 2, 2019 at 1:43 AM Oded Gabbay <[email protected]> wrote: > > > > > > When parsing the address of an internal command buffer, the driver prints > > > an error if the buffer's address is not in the range of the device's DRAM > > > or SRAM memory address space. > > > > > > Use %px to print the real address that the user gave the driver and not a > > > hashed value, so the user will get a clue regarding the origin of his > > > error. > > > > > > Note that if the print occurs, the pointer that is printed is a > > > user's virtual address and not some kind of physical address. > > > > Err, which virtual address space is this? If this is mapped into the > > kernel's virtual address space, this should not be %px... > No, it's not mapped to kernel in any way. > It's supposed to be an address in the device's address space. > As this is an error message, it's either a wrong address in the > device's address space, or it's a user-space virtual address.
Okay, thanks! :) -- Kees Cook
