On Thu, Mar 07, 2019 at 10:23:28AM +0000, Colin Ian King wrote: > On 04/03/2019 06:36, Leon Romanovsky wrote: > > On Sat, Mar 02, 2019 at 11:06:36PM +0000, Colin King wrote: > >> From: Colin Ian King <[email protected]> > >> > >> The non-null check on udata is redundant as this check was performed > >> just a few statements earlier and the check is always true as udata > >> must be non-null at this point. Remove redundant the check on udata > >> and the redundant else part that can never be executed. > >> > >> Detected by CoverityScan, CID#1477317 ("Logically dead code") > >> > >> Signed-off-by: Colin Ian King <[email protected]> > >> --- > >> drivers/infiniband/hw/nes/nes_verbs.c | 73 +++++++++++++-------------- > >> 1 file changed, 34 insertions(+), 39 deletions(-) > >> > >> diff --git a/drivers/infiniband/hw/nes/nes_verbs.c > >> b/drivers/infiniband/hw/nes/nes_verbs.c > >> index 828e4af3f951..526092d435df 100644 > >> --- a/drivers/infiniband/hw/nes/nes_verbs.c > >> +++ b/drivers/infiniband/hw/nes/nes_verbs.c > >> @@ -1039,53 +1039,48 @@ static struct ib_qp *nes_create_qp(struct ib_pd > >> *ibpd, > >> } > >> if (req.user_qp_buffer) > >> nesqp->nesuqp_addr = req.user_qp_buffer; > >> - if (udata) { > >> - nesqp->user_mode = 1; > > > > It was single place where user_mode was set, you should continue and > > remove all code which depends on "if (nesqp->user_mode)". > > This is not the only place where user_mode is being set; we currently have:
ok, It doesn't matter, I'll clean it later with my memory allocation conversion patches. Thanks
signature.asc
Description: PGP signature
