-----Original Message----- > From: [email protected] <platform-driver-x86- > [email protected]> On Behalf Of Jiaxun Yang > Sent: Thursday, March 7, 2019 2:08 AM > To: [email protected] > Cc: [email protected]; [email protected]; ibm-acpi- > [email protected]; [email protected]; linux- > [email protected]; [email protected]; Jiaxun Yang > Subject: [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some > machines > > > [EXTERNAL EMAIL] > > Some AMD based ThinkPads have a firmware bug that calling > "GBDC" will cause bluetooth on Intel wireless cards blocked.
Since this is considered a firmware bug; has the OEM (and IBV) been notified? Is it fixed in a newer version of the firmware? If so, then this should probably only match particular broken firmware versions. > > Probe these models by DMI match and disable bluetooth subdriver > if specified Intel wireless card exist. > > Signed-off-by: Jiaxun Yang <[email protected]> > --- > drivers/platform/x86/thinkpad_acpi.c | 70 ++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 726341f2b638..29e835f9368a 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -79,6 +79,7 @@ > #include <linux/jiffies.h> > #include <linux/workqueue.h> > #include <linux/acpi.h> > +#include <linux/pci.h> > #include <linux/pci_ids.h> > #include <linux/power_supply.h> > #include <sound/core.h> > @@ -4501,11 +4502,80 @@ static void bluetooth_exit(void) > bluetooth_shutdown(); > } > > +static const struct dmi_system_id bt_fwbug_list[] __initconst = { > + { > + .ident = "ThinkPad E485", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KU"), > + }, > + }, > + { > + .ident = "ThinkPad E585", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KV"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MW", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MW"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MX", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MX"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MU", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MU"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MV", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MV"), > + }, > + }, > + {} > +}; > + > +static int __init have_bt_fwbug(void) > +{ > + /* Some AMD based ThinkPads have a firmware bug that calling > + * "GBDC" will cause bluetooth on Intel wireless cards blocked > + */ > + if (dmi_check_system(bt_fwbug_list)) { > + if (pci_get_device(PCI_VENDOR_ID_INTEL, 0x24F3, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x24FD, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x2526, NULL)) > + return 1; > + else > + return 0; > + } else { > + return 0; > + } > +} > + > static int __init bluetooth_init(struct ibm_init_struct *iibm) > { > int res; > int status = 0; > > + if (have_bt_fwbug()) { > + vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > + FW_BUG "disable bluetooth subdriver for Intel cards\n"); > + return 1; > + } > + > vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > "initializing bluetooth subdriver\n"); > > -- > 2.20.1
